mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joerg Schad" <jo...@mesosphere.io>
Subject Re: Review Request 39400: Quota: Implemented quota API.
Date Thu, 19 Nov 2015 17:41:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39400/#review107194
-----------------------------------------------------------



src/master/allocator/mesos/hierarchical.hpp (line 390)
<https://reviews.apache.org/r/39400/#comment166198>

    s/separately/ in addition 
    
    Not really sure about the best formulation here but for me 'separately' implies that it
is not part of the normal sorter anymore.



src/master/allocator/mesos/hierarchical.cpp (line 140)
<https://reviews.apache.org/r/39400/#comment166199>

    s/of/for 
    
    similar issue with separately as above.



src/master/allocator/mesos/hierarchical.cpp (line 141)
<https://reviews.apache.org/r/39400/#comment166200>

    s/dedicated/additional



src/master/allocator/mesos/hierarchical.cpp (line 142)
<https://reviews.apache.org/r/39400/#comment166201>

    s/general/all ?



src/master/allocator/mesos/hierarchical.cpp (line 332)
<https://reviews.apache.org/r/39400/#comment166202>

    s/this/these (or all)?



src/master/allocator/mesos/hierarchical.cpp (line 889)
<https://reviews.apache.org/r/39400/#comment166197>

    s/is not set/has not been set before



src/master/allocator/mesos/hierarchical.cpp (line 903)
<https://reviews.apache.org/r/39400/#comment166190>

    s/an/the



src/master/allocator/mesos/hierarchical.cpp (line 926)
<https://reviews.apache.org/r/39400/#comment166191>

    s/an/the


- Joerg Schad


On Nov. 11, 2015, 10:29 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39400/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2015, 10:29 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and Joseph
Wu.
> 
> 
> Bugs: MESOS-3718
>     https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp cd0d3e0bd234fcf4db9af2e376ea311937204f75

>   src/master/allocator/mesos/hierarchical.cpp 14fef63714721fcda7cea3c28704766efda6d007

> 
> Diff: https://reviews.apache.org/r/39400/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message