mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 39492: Added status endpoint for quota master endpoint.
Date Thu, 19 Nov 2015 14:53:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review107176
-----------------------------------------------------------



include/mesos/quota/quota.proto (line 55)
<https://reviews.apache.org/r/39492/#comment166166>

    What is your message here?



src/master/quota_handler.cpp (line 338)
<https://reviews.apache.org/r/39492/#comment166164>

    s/Status/status
    Do you think it makes sense to add `request.body`.



src/master/quota_handler.cpp (lines 348 - 349)
<https://reviews.apache.org/r/39492/#comment166162>

    We insert a line between code and a comment. Alternatively, you can swap them. However,
IMO the best is to remove L347 and insert a line here.



src/master/quota_handler.cpp (line 354)
<https://reviews.apache.org/r/39492/#comment166161>

    Newline


- Alexander Rukletsov


On Nov. 19, 2015, 12:44 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 12:44 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
>     https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added status handling for quota master endpoint.
> 
> 
> Diffs
> -----
> 
>   include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
>   src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
>   src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
> 
> Diff: https://reviews.apache.org/r/39492/diff/
> 
> 
> Testing
> -------
> 
> Tests are in next Review.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message