mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 39614: Quota: Added Status Validation Tests.
Date Thu, 19 Nov 2015 13:47:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39614/#review107159
-----------------------------------------------------------



src/tests/master_quota_tests.cpp (line 701)
<https://reviews.apache.org/r/39614/#comment166129>

    Why do you call them status validation tests? Do they belong to this test section?



src/tests/master_quota_tests.cpp (line 703)
<https://reviews.apache.org/r/39614/#comment166130>

    3rd person singular, please.



src/tests/master_quota_tests.cpp (lines 703 - 705)
<https://reviews.apache.org/r/39614/#comment166131>

    I'd say "empty quota" is a bit ambiguous. How about `StatusNoQuotas`?



src/tests/master_quota_tests.cpp (line 712)
<https://reviews.apache.org/r/39614/#comment166134>

    Do you want to check status here as well?



src/tests/master_quota_tests.cpp (lines 785 - 787)
<https://reviews.apache.org/r/39614/#comment166138>

    If we create an implicit contract that the status JSON is based on `QuotaStatus` proto—which
I think is a good idea—we should maybe check we can convert the `JSON` to proto.


- Alexander Rukletsov


On Oct. 24, 2015, 7:40 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39614/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2015, 7:40 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
> 
> 
> Bugs: MESOS-3073
>     https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota: Added Status Validation Tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39614/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message