mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 40434: Fixed a problem when an HTTP response cannot be delivered and a promise was broken.
Date Wed, 18 Nov 2015 10:00:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40434/#review107002
-----------------------------------------------------------

Ship it!


It would have been great to clarify in the description that this isn't relevant in the existing
code, right? In particular, if someone calls `deliver` and no process is found, we will drop
and delete the event. In the case of an HttpEvent, this would stall the pipeline forever.
And also, in your subsequent patches, we will introduce the possibility of triggering this
code when a process terminates while HTTP authentication is in process.

- Ben Mahler


On Nov. 18, 2015, 9:15 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40434/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2015, 9:15 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed a problem when an HTTP response cannot be delivered and a promise was broken.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/event.hpp 28ce1928877084f0e1a73fdad789224c86e53f46

> 
> Diff: https://reviews.apache.org/r/40434/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message