mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Qian Zhang" <zhang...@cn.ibm.com>
Subject Re: Review Request 40379: [WIP] MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription
Date Wed, 18 Nov 2015 09:48:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40379/#review107001
-----------------------------------------------------------



src/slave/slave.cpp (lines 4419 - 4427)
<https://reviews.apache.org/r/40379/#comment165879>

    Suggest to add some comments for these newly added code, e.g., why do we set type as USAGE_SLACK?
This will help other devs better understand this feature.


- Qian Zhang


On Nov. 17, 2015, 4:41 p.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40379/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2015, 4:41 p.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-3930
>     https://issues.apache.org/jira/browse/MESOS-3930
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In Optimistic Offer Phase 1, it introduce `RevocableInfo::type`: USAGE_SLACK for Oversubscription
and ALLOCATION_SLACK for Optimistic Offer. Slave helps to update `RevocableInfo::type` for
Oversubscription.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp d1126f00d947fdb4823b0c495335b743254ac7ee 
> 
> Diff: https://reviews.apache.org/r/40379/diff/
> 
> 
> Testing
> -------
> 
> make (make check is on-going)
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message