mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Mann" <g...@mesosphere.io>
Subject Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.
Date Mon, 16 Nov 2015 23:53:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39988/
-----------------------------------------------------------

(Updated Nov. 16, 2015, 11:53 p.m.)


Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.


Changes
-------

Rebase.


Bugs: MESOS-3062
    https://issues.apache.org/jira/browse/MESOS-3062


Repository: mesos


Description
-------

Added authorization for dynamic reservation master endpoints.
Note: this review is continued from https://reviews.apache.org/r/37126/


Diffs (updated)
-----

  src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
  src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
  src/tests/reservation_endpoints_tests.cpp 1552e4537c4f4d79bfa4bc17ccab2df630bc32a4 

Diff: https://reviews.apache.org/r/39988/diff/


Testing
-------

This is the fourth in a chain of 5 patches. Added new reservation endpoints tests to validate
authorization of reserve and unreserve operations using ACLs. `make check` was run to test
after all patches were applied.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message