mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Bannier" <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 39991: fetcher should extract from .tar archive
Date Mon, 16 Nov 2015 10:18:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39991/#review106629
-----------------------------------------------------------

Ship it!


I believe the copy-n-paste should be fine here until we add a third test case; then would
definitely be the time to got for a parametrized test.

- Benjamin Bannier


On Nov. 12, 2015, 1:47 a.m., Bhuvan Arumugam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39991/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2015, 1:47 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: mesos-2935
>     https://issues.apache.org/jira/browse/mesos-2935
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> fetcher should extract from .tar archive
> 
> 
> Diffs
> -----
> 
>   src/launcher/fetcher.cpp 8fb6c83981a141df9c0a8a6f8267230bef64f218 
>   src/tests/fetcher_tests.cpp 46d0690887b6b6af4c7102753cae8db0a375fa08 
> 
> Diff: https://reviews.apache.org/r/39991/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bhuvan Arumugam
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message