mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Conway" <neil.con...@gmail.com>
Subject Re: Review Request 39230: Added prevention of SASL deprecation warnings all around its invocations on OS X.
Date Sun, 15 Nov 2015 12:53:02 GMT


> On Nov. 2, 2015, 6:44 p.m., Alex Clemmer wrote:
> > configure.ac, line 758
> > <https://reviews.apache.org/r/39230/diff/3/?file=1103165#file1103165line758>
> >
> >     Sorry I'm super late to the party. Does it make sense to add these to the CMake
build system as well?

Using #pragma would apply to CMake as well, I believe. i.e., should work for cmake as-is.


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39230/#review104753
-----------------------------------------------------------


On Oct. 22, 2015, 10:02 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39230/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2015, 10:02 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3030
>     https://issues.apache.org/jira/browse/MESOS-3030
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   configure.ac 66f9b32 
>   src/authentication/cram_md5/authenticatee.cpp b03b44a 
>   src/authentication/cram_md5/authenticator.cpp f238872 
>   src/authentication/cram_md5/auxprop.cpp abf0f8d 
> 
> Diff: https://reviews.apache.org/r/39230/diff/
> 
> 
> Testing
> -------
> 
> ./configure && make check 
> OSX, clang3.7 + gcc4.9
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message