mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Artem Harutyunyan" <ar...@mesosphere.io>
Subject Re: Review Request 39410: Added support for github to apply-reviews.py.
Date Sat, 14 Nov 2015 17:01:15 GMT


> On Nov. 10, 2015, 12:18 p.m., Vinod Kone wrote:
> > support/apply-reviews.py, line 192
> > <https://reviews.apache.org/r/39410/diff/13-14/?file=1119828#file1119828line192>
> >
> >     s/-e/--amend/ ?

Turns out `--amend` is very different from `-e`. `--amend` causes all commits in the branch
to be squashed together into one. Excerpt from the man page (https://git-scm.com/docs/git-commit):

```
...
It is a rough equivalent for:


$ git reset --soft HEAD^
$ ... do something else to come up with the right tree ...
$ git commit -c ORIG_HEAD
```


- Artem


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39410/#review105939
-----------------------------------------------------------


On Nov. 12, 2015, 10:03 a.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39410/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2015, 10:03 a.m.)
> 
> 
> Review request for mesos, Adam B, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and
Vinod Kone.
> 
> 
> Bugs: MESOS-3859
>     https://issues.apache.org/jira/browse/MESOS-3859
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added support for github to apply-reviews.py.
> 
> 
> Diffs
> -----
> 
>   support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 
> 
> Diff: https://reviews.apache.org/r/39410/diff/
> 
> 
> Testing
> -------
> 
> Tested with python 2.7
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message