mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Conway" <>
Subject Re: Review Request 39946: Moved definition of ctors and dtors for mock classes out of header file.
Date Sat, 14 Nov 2015 03:11:45 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 14, 2015, 3:11 a.m.)

Review request for mesos and Joris Van Remoortere.


Whitespace fix.

Bugs: MESOS-3827

Repository: mesos


As discussed in MESOS-3827, this can improve compilation time of classes that
use GMock. On my system, this improves the compilation time of the unit tests by
about 8%.

Note that we can't use this technique with TestAllocator, because it is

Diffs (updated)

  src/ 92d07c3da897c7664c63e2af91d45921d66f64aa 
  src/tests/containerizer/launcher.hpp f587dda7a2a968f96acb8cb316fd4079d37d9ca2 
  src/tests/containerizer/launcher.cpp PRE-CREATION 
  src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed 
  src/tests/mesos.cpp 5667e961fe70d15defbb127c174e91376ca9de3d 


Testing (updated)

make check


Neil Conway

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message