mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 40285: Changed untar process to pipe STDOUT and STDERR.
Date Fri, 13 Nov 2015 16:49:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40285/#review106435
-----------------------------------------------------------



src/slave/containerizer/mesos/provisioner/docker/puller.cpp (line 78)
<https://reviews.apache.org/r/40285/#comment165171>

    This would then print the whole untar structure on every layer and every local image.
    
    What we should instead is that when untar fails we should print the stderr message from
the pipe instead.


- Timothy Chen


On Nov. 13, 2015, 8:13 a.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40285/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2015, 8:13 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> By piping stdout and stderr to logs, it would be easier to  debug problems with untar.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 13f5e2877f4d7951e79ba07073a42848217604b3

> 
> Diff: https://reviews.apache.org/r/40285/diff/
> 
> 
> Testing
> -------
> 
> make check;
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message