mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Artem Harutyunyan" <ar...@mesosphere.io>
Subject Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.
Date Thu, 12 Nov 2015 13:36:49 GMT


> On Nov. 11, 2015, 5:56 a.m., Ben Mahler wrote:
> > support/apply-reviews.py, lines 158-164
> > <https://reviews.apache.org/r/38883/diff/16/?file=1119827#file1119827line158>
> >
> >     The url added to the message here doesn't match the existing format used by
apply-review.sh:
> >     
> >     ```
> >     Review: https://reviews.apache.org/api/review-requests/38876/
> >     ```
> >     
> >     vs the expected:
> >     
> >     ```
> >     Review: https://reviews.apache.org/r/38876
> >     ```

Fixed in https://reviews.apache.org/r/40225/.


- Artem


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38883/#review106053
-----------------------------------------------------------


On Nov. 9, 2015, 6:18 a.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38883/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2015, 6:18 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, Joseph Wu, and Vinod
Kone.
> 
> 
> Bugs: MESOS-3468
>     https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38883/diff/
> 
> 
> Testing
> -------
> 
> Tested the script with python 2.7.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message