mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.
Date Wed, 11 Nov 2015 13:56:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38883/#review106053
-----------------------------------------------------------



support/apply-reviews.py (lines 148 - 154)
<https://reviews.apache.org/r/38883/#comment164778>

    The url added to the message here doesn't match the existing format used by apply-review.sh:
    
    ```
    Review: https://reviews.apache.org/api/review-requests/38876/
    ```
    
    vs the expected:
    
    ```
    Review: https://reviews.apache.org/r/38876
    ```


- Ben Mahler


On Nov. 9, 2015, 2:18 p.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38883/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2015, 2:18 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, Joseph Wu, and Vinod
Kone.
> 
> 
> Bugs: MESOS-3468
>     https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38883/diff/
> 
> 
> Testing
> -------
> 
> Tested the script with python 2.7.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message