mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 39410: Added support for github to apply-reviews.py.
Date Mon, 09 Nov 2015 22:07:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39410/#review105728
-----------------------------------------------------------

Ship it!



support/apply-reviews.py (line 42)
<https://reviews.apache.org/r/39410/#comment164355>

    the comment only mentions Review Board but the code works for github too?



support/apply-reviews.py (lines 140 - 145)
<https://reviews.apache.org/r/39410/#comment164381>

    More and more I look at this code, I feel like the global options is not a great idea.
I think if these functions took explicit arguments instead of depending on global options,
it would make it much easy to reason about.
    
    Can you add a TODO for now to clean this up.



support/apply-reviews.py (line 143)
<https://reviews.apache.org/r/39410/#comment164374>

    new line please.



support/apply-reviews.py (line 145)
<https://reviews.apache.org/r/39410/#comment164375>

    new line please.



support/apply-reviews.py (line 149)
<https://reviews.apache.org/r/39410/#comment164376>

    s/the//



support/apply-reviews.py (line 193)
<https://reviews.apache.org/r/39410/#comment164380>

    Needs a comment on what this returns.



support/apply-reviews.py (lines 219 - 220)
<https://reviews.apache.org/r/39410/#comment164379>

    indentation.



support/apply-reviews.py (lines 259 - 260)
<https://reviews.apache.org/r/39410/#comment164378>

    indentation.



support/apply-reviews.py (line 275)
<https://reviews.apache.org/r/39410/#comment164377>

    why the temp variable?


- Vinod Kone


On Nov. 9, 2015, 3:32 p.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39410/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2015, 3:32 p.m.)
> 
> 
> Review request for mesos, Adam B, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and
Vinod Kone.
> 
> 
> Bugs: MESOS-3859
>     https://issues.apache.org/jira/browse/MESOS-3859
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added support for github to apply-reviews.py.
> 
> 
> Diffs
> -----
> 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39410/diff/
> 
> 
> Testing
> -------
> 
> Tested with python 2.7
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message