mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <toensh...@me.com>
Subject Re: Review Request 39595: Took mtime into account in the fetcher cache.
Date Mon, 09 Nov 2015 13:01:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39595/#review105587
-----------------------------------------------------------



src/hdfs/hdfs.hpp (lines 204 - 208)
<https://reviews.apache.org/r/39595/#comment164205>

    The examples of our doxygen-styleguide suggest that we should be using C style comments.
Same goes with the parameter description which should be starting with a capital letter.
    
    ```
      /**
       * Obtain path modification time.
       *
       * @param path Path to the resource to query.
       * @return Returns the last modification time of the resource in seconds
       *   since the POSIX epoch, or an Error if it cannot be retrieved.
       */
    ```



src/hdfs/hdfs.hpp (line 237)
<https://reviews.apache.org/r/39595/#comment164207>

    Good catch.



src/slave/containerizer/fetcher.hpp (line 255)
<https://reviews.apache.org/r/39595/#comment164206>

    Let's only use the key here...
    
    ```
    bool hasKey(const std::string& key);
    ```



src/slave/containerizer/fetcher.cpp (line 318)
<https://reviews.apache.org/r/39595/#comment164208>

    `if(sizeAndMtime.size.isError()) {` ?



src/slave/containerizer/fetcher.cpp (line 325)
<https://reviews.apache.org/r/39595/#comment164209>

    This is not how we wrap ternary operator expressions. We use variable indentation...
    
    ```
        const auto optionalMtime = Option<long>(
            sizeAndMtime.mtime.isSome() ? Option<long>(sizeAndMtime.mtime.get())
                                        : None());
    ```


- Till Toenshoff


On Nov. 6, 2015, 7:52 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39595/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2015, 7:52 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3785
>     https://issues.apache.org/jira/browse/MESOS-3785
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also added function to query mtime of HDFS resource.
> 
> 
> Diffs
> -----
> 
>   src/hdfs/hdfs.hpp 42c150186f2ce676407e4e00e84bd7e38063d9ba 
>   src/slave/containerizer/fetcher.hpp c7518a36f6344841880dbb11bfce603fd2791fc0 
>   src/slave/containerizer/fetcher.cpp e0d02d5f8f4f6e930a2ae6abe365548af6d1b01f 
>   src/tests/fetcher_cache_tests.cpp 0b3245105b4c1efae54f0bc34f672290819a6f0b 
> 
> Diff: https://reviews.apache.org/r/39595/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message