mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Conway" <neil.con...@gmail.com>
Subject Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.
Date Sat, 07 Nov 2015 01:16:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39988/#review105547
-----------------------------------------------------------



src/master/master.hpp (line 981)
<https://reviews.apache.org/r/39988/#comment164165>

    Should update the comment for new function parameter.



src/tests/reservation_endpoints_tests.cpp (line 834)
<https://reviews.apache.org/r/39988/#comment164172>

    Probably don't want this whitespace?



src/tests/reservation_endpoints_tests.cpp (line 923)
<https://reviews.apache.org/r/39988/#comment164173>

    Probably don't want this whitespace?



src/tests/reservation_endpoints_tests.cpp (line 1001)
<https://reviews.apache.org/r/39988/#comment164174>

    Whitespace.


- Neil Conway


On Nov. 6, 2015, 11:58 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39988/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2015, 11:58 p.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3062
>     https://issues.apache.org/jira/browse/MESOS-3062
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added authorization for dynamic reservation master endpoints.
> Note: this review is continued from https://reviews.apache.org/r/37126/
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 9d20346460b4f9659aacba3fcb950ab564ba9d0d 
>   src/master/master.hpp b19f23be135d191ce119cf87fd25c4d6746faed3 
>   src/tests/reservation_endpoints_tests.cpp f5f9c4834779a3a84d12d9be77e674e2d6088b5d

> 
> Diff: https://reviews.apache.org/r/39988/diff/
> 
> 
> Testing
> -------
> 
> This is the fourth in a chain of 5 patches. Added new reservation endpoints tests to
validate authorization of reserve and unreserve operations using ACLs. `make check` was run
to test after all patches were applied.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message