mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Mann" <g...@mesosphere.io>
Subject Re: Review Request 39987: [3/5] Added 'Master::authorize' for Reserve/Unreserve.
Date Fri, 06 Nov 2015 23:56:29 GMT


> On Nov. 6, 2015, 7:38 a.m., Guangya Liu wrote:
> > src/master/master.hpp, lines 688-690
> > <https://reviews.apache.org/r/39987/diff/1/?file=1116941#file1116941line688>
> >
> >     Can the comments be limitted to 70 chars?

As discussed in other reviews, we are currently wrapping comments at 80 characters.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39987/#review105379
-----------------------------------------------------------


On Nov. 5, 2015, 9:52 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39987/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 9:52 p.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3062
>     https://issues.apache.org/jira/browse/MESOS-3062
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added 'Master::authorize' for Reserve/Unreserve.
> Note: this review is continued from https://reviews.apache.org/r/37125/
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp b19f23be135d191ce119cf87fd25c4d6746faed3 
>   src/master/master.cpp cbae27e7a4059a72bc69e152ec8adaf4ef725965 
> 
> Diff: https://reviews.apache.org/r/39987/diff/
> 
> 
> Testing
> -------
> 
> This is the third in a chain of 5 patches. `make check` was used to test after all patches
were applied.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message