mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Mann" <g...@mesosphere.io>
Subject Re: Review Request 39986: [2/5] Enabled the Authorizer to handle Reserve/Unreserve ACLs.
Date Fri, 06 Nov 2015 23:54:44 GMT


> On Nov. 6, 2015, 12:07 a.m., Till Toenshoff wrote:
> > src/tests/authorization_tests.cpp, line 411
> > <https://reviews.apache.org/r/39986/diff/1/?file=1116939#file1116939line411>
> >
> >     You already did a great job commenting your tests but could you also please
add 1-2 lines of comment above all test function heads to briefly introduce their purpose?
We made that a pattern we try to follow for all new tests.

Good call, thanks Till!


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39986/#review105323
-----------------------------------------------------------


On Nov. 6, 2015, 11:53 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39986/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2015, 11:53 p.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3062
>     https://issues.apache.org/jira/browse/MESOS-3062
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enabled the Authorizer to handle Reserve/Unreserve ACLs.
> Note: this review is continued from https://reviews.apache.org/r/37110/
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/authorizer.hpp d667a52f90f970a313580446a5a006cec4b5e25b 
>   src/authorizer/local/authorizer.hpp 32de102fd588f029882ef2222121ca83a7410c65 
>   src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773 
>   src/tests/authorization_tests.cpp 4940450193d89a8f11a15d31723119fa26cdab1b 
>   src/tests/mesos.hpp f731ac3284a5793b6bf510d3a5b742cbe0938217 
> 
> Diff: https://reviews.apache.org/r/39986/diff/
> 
> 
> Testing
> -------
> 
> The is the second in a chain of 5 patches. This diff includes new tests for the authorization
of reserve and unreserve operations via ACLs. `make check` was used to test after all patches
were applied.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message