mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 40010: Put authorize logic for teardown into a common function.
Date Fri, 06 Nov 2015 17:55:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40010/#review105479
-----------------------------------------------------------


Patch looks great!

Reviews applied: [40010]

All tests passed.

- Mesos ReviewBot


On Nov. 6, 2015, 10:41 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40010/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2015, 10:41 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3838
>     https://issues.apache.org/jira/browse/MESOS-3838
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The mesos now have authorizeTask, authorizeFramework etc, it is
> better to put authorize logic for teardown into a common function
> authorizeTeardown.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 9d20346460b4f9659aacba3fcb950ab564ba9d0d 
>   src/master/master.hpp b19f23be135d191ce119cf87fd25c4d6746faed3 
>   src/master/master.cpp cbae27e7a4059a72bc69e152ec8adaf4ef725965 
> 
> Diff: https://reviews.apache.org/r/40010/diff/
> 
> 
> Testing
> -------
> 
> Ubuntu 14.04
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message