mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <toensh...@me.com>
Subject Re: Review Request 40013: Stout: Corrected style of Makefiles.
Date Fri, 06 Nov 2015 12:02:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40013/#review105412
-----------------------------------------------------------

Ship it!


Thanks again Alex. Will commit them once you confirmed a successful `make distcheck` in the
`Testing done` and/or the Apache CI ran through this patchset successfully.

- Till Toenshoff


On Nov. 6, 2015, 11:07 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40013/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2015, 11:07 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is not a full standartization of Makefile format, however, it is a step towards
consistency. This patch focuses mainly on the order of files and corrects obvious issues.
These are guidelines behind the change:
> 
> - Files in the same folder should appear in lexicographical order.
> - Subfolders should appear in lexicographical order either after files or mixed with
them (depending on the current consensus in the file).
> - Though tabs are preferred, spaces are not replaced if they are current consensus in
the file or current section.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 67b142bbc2d80f40a1e893cc5813d58dd2aa8381

> 
> Diff: https://reviews.apache.org/r/40013/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message