mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Review Request 40012: Libprocess: Corrected style of Makefiles.
Date Fri, 06 Nov 2015 11:07:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40012/
-----------------------------------------------------------

Review request for mesos and Till Toenshoff.


Repository: mesos


Description
-------

This is not a full standartization of Makefile format, however, it is a step towards consistency.
This patch focuses mainly on the order of files and corrects obvious issues. These are guidelines
behind the change:

- Files in the same folder should appear in lexicographical order.
- Subfolders should appear in lexicographical order either after files or mixed with them
(depending on the current consensus in the file).
- Though tabs are preferred, spaces are not replaced if they are current consensus in the
file or current section.


Diffs
-----

  3rdparty/libprocess/3rdparty/Makefile.am 53e83d4905945593e174601a0b791d01824dc34b 
  3rdparty/libprocess/Makefile.am 404a7438e7cd53d9295fe6025b5af5fb83df939b 
  3rdparty/libprocess/include/Makefile.am fcc62e99b92b9d2e7ab344e561a06dd6de1fef7e 

Diff: https://reviews.apache.org/r/40012/diff/


Testing
-------

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message