mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Conway" <>
Subject Re: Review Request 39946: Moved definition of ctors and dtors for mock classes out of header file.
Date Thu, 05 Nov 2015 00:56:08 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 5, 2015, 12:56 a.m.)

Review request for mesos and Joris Van Remoortere.


Fix ctor/dtor per BenM.

Bugs: MESOS-3827

Repository: mesos


As discussed in MESOS-3827, this can improve compilation time of classes that
use GMock. On my system, this improves the compilation time of the unit tests by
about 8%.

Note that we can't use this technique with TestAllocator, because it is

Diffs (updated)

  src/ d6eb302f0e812a777f51f421deef89140871a1db 
  src/tests/containerizer/launcher.hpp 5d34bab789bdafe71d94e8ec263710c50b83e180 
  src/tests/containerizer/launcher.cpp PRE-CREATION 
  src/tests/mesos.hpp f731ac3284a5793b6bf510d3a5b742cbe0938217 
  src/tests/mesos.cpp ab2d85b091d121113931e4190a5b496901dcd7a5 




Neil Conway

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message