mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Artem Harutyunyan" <ar...@mesosphere.io>
Subject Re: Review Request 39410: Added support for github to apply-reviews.py.
Date Wed, 04 Nov 2015 22:44:46 GMT


> On Nov. 2, 2015, 4:55 p.m., Vinod Kone wrote:
> > support/apply-reviews.py, line 132
> > <https://reviews.apache.org/r/39410/diff/7-9/?file=1105478#file1105478line132>
> >
> >     this is weird too. a 'remove patch' function which takes optional patch as an
argument.

Added a comment to clarify.


> On Nov. 2, 2015, 4:55 p.m., Vinod Kone wrote:
> > support/apply-reviews.py, lines 137-140
> > <https://reviews.apache.org/r/39410/diff/7-9/?file=1105478#file1105478line137>
> >
> >     This log shouldn't be in the caller instead of this function.

It would be trivial to move the check and the comment to a calling function, however it would
mean that we will be making an exception and passing the `dry_run` argument down from the
higher level function. I refactored the code, added an `if` statement. Hopefully it makes
it easier to read and makes the intent more explicit. Please let me know if you still believe
that this should be improved further.


> On Nov. 2, 2015, 4:55 p.m., Vinod Kone wrote:
> > support/apply-reviews.py, line 48
> > <https://reviews.apache.org/r/39410/diff/7-9/?file=1105478#file1105478line48>
> >
> >     i have seen this in the previous reviews too. so wanted to confirm.
> >     
> >     why do you use urlparse.urljoin() for the latter part of this url, but use "/"
for the former part?

>From what I've seen `urljoin` does not support just joing parts of URLs. It treats the
first part as a base, and so it's really not obvious how one can use it to do what I need
to do. I am going to go ahead and get rid of it altogether. I think I'll just use .format
everywhere.


- Artem


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39410/#review104831
-----------------------------------------------------------


On Oct. 30, 2015, 1:55 a.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39410/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2015, 1:55 a.m.)
> 
> 
> Review request for mesos, Adam B, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and
Vinod Kone.
> 
> 
> Bugs: MESOS-3468
>     https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added support for github to apply-reviews.py.
> 
> 
> Diffs
> -----
> 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39410/diff/
> 
> 
> Testing
> -------
> 
> Tested with python 2.7
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message