mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Conway" <neil.con...@gmail.com>
Subject Re: Review Request 39886: Added documentation about roles.
Date Tue, 03 Nov 2015 19:52:02 GMT


> On Nov. 3, 2015, 8:43 a.m., Alexander Rukletsov wrote:
> > docs/roles.md, line 12
> > <https://reviews.apache.org/r/39886/diff/1/?file=1114346#file1114346line12>
> >
> >     Do you want to be consistent with the existing codebase and continue use "slave"
for now?

We already use "agent" in various places right now (in both code and docs), so I think this
is okay as-is.


> On Nov. 3, 2015, 8:43 a.m., Alexander Rukletsov wrote:
> > docs/roles.md, line 22
> > <https://reviews.apache.org/r/39886/diff/1/?file=1114346#file1114346line22>
> >
> >     Shall we leave a note here that our intention is to add dynamic roles ASAP?

Not sure this is that important for user-focused docs. When we add dynamic roles, we can update
the docs.


> On Nov. 3, 2015, 8:43 a.m., Alexander Rukletsov wrote:
> > docs/roles.md, line 10
> > <https://reviews.apache.org/r/39886/diff/1/?file=1114346#file1114346line10>
> >
> >     Roles also introduce one level in the hierarchy of resource allocation. Also
putting a framework into a role is the only way to leverage some sort of prioritization (role
weights). Similar to what you say at the bottom of the doc, I would say it makes sense to
mention it here as a use case as well.

Good point! Done.


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39886/#review104884
-----------------------------------------------------------


On Nov. 3, 2015, 7:51 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39886/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2015, 7:51 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3819
>     https://issues.apache.org/jira/browse/MESOS-3819
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also removed a redundant (and arguably slightly wrong) assertion about the
> status of static reservations.
> 
> 
> Diffs
> -----
> 
>   docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447 
>   docs/authorization.md 2a5e74782754e446184a297f91112e9f94077896 
>   docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
>   docs/home.md af886257348f24cfeecfc726255d8d45d68af2db 
>   docs/reservation.md 69bde760ece59c68b04a903026b5903e2091ceb0 
>   docs/roles.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39886/diff/
> 
> 
> Testing
> -------
> 
> Previewed with the support/site Docker container.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message