mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Klaus Ma" <>
Subject Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField
Date Tue, 03 Nov 2015 13:38:48 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 3, 2015, 9:38 p.m.)

Review request for mesos, Alexander Rukletsov, Michael Park, and Jan Schlicht.


Address comments

Bugs: MESOS-3405

Repository: mesos


Currently, `stout/protobuf.hpp` provides a `JSON::Protobuf` utility which converts a `google::protobuf::Message`
into a `JSON::Object`.
We should add the support for `google::protobuf::RepeatedPtrField<T>` by introducing
overloaded functions.

Diffs (updated)

  src/common/http.cpp f56d8a1 
  src/docker/executor.cpp d4c05c2 
  src/examples/persistent_volume_framework.cpp 176ac3d 
  src/launcher/executor.cpp 50b3c6e 
  src/master/contender.cpp c641305 
  src/master/http.cpp 093f793 
  src/master/maintenance.cpp 5fe9358 
  src/master/registrar.cpp 1117232 
  src/slave/containerizer/fetcher.cpp e0d02d5 
  src/slave/containerizer/mesos/containerizer.cpp 9fd69c1 
  src/slave/monitor.cpp aa6e958 
  src/tests/containerizer/launch_tests.cpp de655ec 
  src/tests/fault_tolerance_tests.cpp f78a291 
  src/tests/master_maintenance_tests.cpp e89ce3b 
  src/tests/master_tests.cpp ee24739 
  src/tests/mesos.cpp ab2d85b 
  src/tests/monitor_tests.cpp 583e711 
  src/tests/reservation_endpoints_tests.cpp f5f9c48 
  src/tests/resources_tests.cpp 6584fc6 
  src/tests/scheduler_http_api_tests.cpp b6f6e91 
  src/tests/script.cpp bcc1fab 
  src/tests/slave_tests.cpp 91dbdba 
  src/usage/main.cpp 86fd796 



make check


Klaus Ma

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message