mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 39886: Added documentation about roles.
Date Tue, 03 Nov 2015 08:43:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39886/#review104884
-----------------------------------------------------------



docs/roles.md (line 10)
<https://reviews.apache.org/r/39886/#comment163143>

    Roles also introduce one level in the hierarchy of resource allocation. Also putting a
framework into a role is the only way to leverage some sort of prioritization (role weights).
Similar to what you say at the bottom of the doc, I would say it makes sense to mention it
here as a use case as well.



docs/roles.md (line 12)
<https://reviews.apache.org/r/39886/#comment163141>

    Do you want to be consistent with the existing codebase and continue use "slave" for now?



docs/roles.md (line 22)
<https://reviews.apache.org/r/39886/#comment163144>

    Shall we leave a note here that our intention is to add dynamic roles ASAP?


- Alexander Rukletsov


On Nov. 3, 2015, 1:51 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39886/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2015, 1:51 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3819
>     https://issues.apache.org/jira/browse/MESOS-3819
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also removed a redundant (and arguably slightly wrong) assertion about the
> status of static reservations.
> 
> 
> Diffs
> -----
> 
>   docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447 
>   docs/configuration.md e66013ad0b951049df645ff90907f19ae8081cc2 
>   docs/home.md af886257348f24cfeecfc726255d8d45d68af2db 
>   docs/reservation.md 69bde760ece59c68b04a903026b5903e2091ceb0 
>   docs/roles.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39886/diff/
> 
> 
> Testing
> -------
> 
> Previewed with the support/site Docker container.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message