mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 39869: Added provisioner TestStore.
Date Tue, 03 Nov 2015 01:11:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39869/#review104840
-----------------------------------------------------------

Ship it!



src/tests/containerizer/store.hpp (line 80)
<https://reviews.apache.org/r/39869/#comment163105>

    Add parathesis around initializing list:
    
    ```
    return vector<string>({rootfs.get()->root});
    ```


- Jie Yu


On Nov. 2, 2015, 7:04 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39869/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2015, 7:04 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added provisioner TestStore.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/store.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39869/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message