mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.
Date Tue, 03 Nov 2015 00:14:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38883/#review104828
-----------------------------------------------------------



support/apply-reviews.py (line 63)
<https://reviews.apache.org/r/38883/#comment163080>

    kill the period at the end of the log statement.
    
    here and everywhere else.



support/apply-reviews.py (line 75)
<https://reviews.apache.org/r/38883/#comment163081>

    ditto.
    
    kill the period at the end of the log statement.



support/apply-reviews.py (line 120)
<https://reviews.apache.org/r/38883/#comment163083>

    i would put the "."on the next line.



support/apply-reviews.py (line 133)
<https://reviews.apache.org/r/38883/#comment163084>

    ditto. "." on the nextline.



support/apply-reviews.py (line 144)
<https://reviews.apache.org/r/38883/#comment163085>

    dot on the next line.



support/apply-reviews.py (line 155)
<https://reviews.apache.org/r/38883/#comment163086>

    ".format" should be aligned with '{summary..' ?


- Vinod Kone


On Oct. 30, 2015, 8:54 a.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38883/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2015, 8:54 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, Joseph Wu, and Vinod
Kone.
> 
> 
> Bugs: MESOS-3468
>     https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38883/diff/
> 
> 
> Testing
> -------
> 
> Tested the script with python 2.7.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message