mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.
Date Mon, 02 Nov 2015 20:43:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review104784
-----------------------------------------------------------


Where's the `Makefile` change?


3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (line 43)
<https://reviews.apache.org/r/39019/#comment163028>

    Presumably, this will always be true for Stout.  So do we need the `#ifdef`?



3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp (lines 50 - 52)
<https://reviews.apache.org/r/39019/#comment163025>

    Maybe add a `// Forward declarations.` comment here.


- Joseph Wu


On Oct. 29, 2015, 10:59 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39019/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2015, 10:59 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3441
>     https://issues.apache.org/jira/browse/MESOS-3441
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Added dirent compat code for non-Unix systems.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp PRE-CREATION

>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027

> 
> Diff: https://reviews.apache.org/r/39019/diff/
> 
> 
> Testing
> -------
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message