mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jojy Varghese" <j...@mesosphere.io>
Subject Re: Review Request 39866: Added containerInfo support for tasks in mesos containerizer.
Date Mon, 02 Nov 2015 20:19:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39866/#review104782
-----------------------------------------------------------



src/slave/containerizer/mesos/containerizer.cpp (line 578)
<https://reviews.apache.org/r/39866/#comment163022>

    Wondering if this means that we can use ContainerInfo as a predicate for "launch" inside
the "composing" containerizer? Today we call "launch" on the containerizer(docker or mesos)
and let the "luanch" decide if it can handle the task. Now that we have the information right
away at the composing containerizer, maybe we can use that?


- Jojy Varghese


On Nov. 2, 2015, 6:59 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39866/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2015, 6:59 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added containerInfo support for tasks in mesos containerizer.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.hpp 4aad8a3be43b331efc6b8157b2fae090df16c1b4

>   src/slave/containerizer/mesos/containerizer.cpp 9fd69c1738e2300dbb843d259727010e24523cff

> 
> Diff: https://reviews.apache.org/r/39866/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message