mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kapil Arya" <ka...@mesosphere.io>
Subject Re: Review Request 39502: [DO NOT COMMIT] Sync v1/mesos.proto with docker, QoS, and AppC changes.
Date Mon, 02 Nov 2015 20:14:25 GMT


> On Oct. 21, 2015, 3:31 p.m., Kapil Arya wrote:
> > Ship It!
> 
> Joseph Wu wrote:
>     Just to confirm, https://reviews.apache.org/r/38367/diff/4#0 was omitted from V1
unintentionally?

Yes, that was an oversight on my end. Thanks for fixing this, Joseph!!


- Kapil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39502/#review103456
-----------------------------------------------------------


On Oct. 26, 2015, 5:27 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39502/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2015, 5:27 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, Joris Van Remoortere, Kapil Arya,
Niklas Nielsen, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added in reviews:
> 
> * https://reviews.apache.org/r/37196/
> * https://reviews.apache.org/r/37308/ <- Confirmed as unintentional
> * https://reviews.apache.org/r/38253/
> * https://reviews.apache.org/r/38367/
> ** NetworkInfo moved up the review chain.
> * https://github.com/apache/mesos/commit/140311f263a6ae54d3d211c9c91e4bf55d2eb0f1
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/mesos.proto 8131778fe5c5f3a47ae9300a811e3d857a22da6a 
> 
> Diff: https://reviews.apache.org/r/39502/diff/
> 
> 
> Testing
> -------
> 
> `make`
> 
> For now, this review is meant for checking which of these differences are intentional.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message