mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 39873: Fixed master to properly handle status updates when multiple of them are enqueued on the slave.
Date Mon, 02 Nov 2015 20:13:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39873/#review104779
-----------------------------------------------------------



src/master/master.cpp (lines 6024 - 6028)
<https://reviews.apache.org/r/39873/#comment163019>

    The movement around this seems to be the key part of this patch, is it possible to isolate
the fix in a patch, on top of a patch where the logging / 0.21.0 bits are updated?


- Ben Mahler


On Nov. 2, 2015, 7:36 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39873/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2015, 7:36 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The master now doesn't change the latest state of a task if it has already terminated.
But it still updates the status update state and uuid.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 9f4586e668a2141f4937497d42853fbdea7751a5 
> 
> Diff: https://reviews.apache.org/r/39873/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Ran the "RecoverCompletedExecutor" test 100 times as it was failing most of the time
without this fix.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message