mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <>
Subject Re: Review Request 39791: Updated createStatusUpdate() to unset StatusUpdate.uuid instead of setting it to an empty string.
Date Mon, 02 Nov 2015 19:31:48 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 2, 2015, 7:31 p.m.)

Review request for mesos, Anand Mazumdar and Ben Mahler.


adjusted jaggedness of the comment. NNFR.

Repository: mesos


As the deleted comment says, we were setting it to emtpy because the 'uuid' was a required
field until 0.22.x. Since we are at 0.26 now, it should be safe to just unset it.

Diffs (updated)

  src/common/protobuf_utils.cpp 1e795dcc90b2225ad7b0a124dbdcdabdc9d2e6aa 
  src/messages/messages.proto 9a1564ff38fa1b984e92cb0abfde2108385f9e2a 



make check


Vinod Kone

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message