mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Re: Review Request 39005: stout: Added thread-safe replacement for strerror.
Date Mon, 02 Nov 2015 19:13:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39005/#review104760
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp (line 52)
<https://reviews.apache.org/r/39005/#comment163003>

    `contain a bug that might where` seems to be missing a word?



3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp (lines 1045 - 1076)
<https://reviews.apache.org/r/39005/#comment163002>

    Can we please move this to its own tests file so that we can run it on Windows too? `os_test.cpp`
has is too big and full of unimplemented stuff to add Windows support right now.


- Alex Clemmer


On Oct. 23, 2015, 7:49 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39005/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 7:49 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3551
>     https://issues.apache.org/jira/browse/MESOS-3551
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds a thread-safe wrapper around strerror_r which has semantics similar to strerror.
We plan to use this at call sites currently relying on strerror.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am ba2836a72ceee948cb43364e80ada9f132f33d04

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff

> 
> Diff: https://reviews.apache.org/r/39005/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message