mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <gyliu...@gmail.com>
Subject Re: Review Request 39791: Updated createStatusUpdate() to unset StatusUpdate.uuid instead of setting it to an empty string.
Date Sat, 31 Oct 2015 08:44:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39791/#review104641
-----------------------------------------------------------

Ship it!


Ship It!

- Guangya Liu


On 十月 30, 2015, 12:21 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39791/
> -----------------------------------------------------------
> 
> (Updated 十月 30, 2015, 12:21 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> As the deleted comment says, we were setting it to emtpy because the 'uuid' was a required
field until 0.22.x. Since we are at 0.26 now, it should be safe to just unset it.
> 
> 
> Diffs
> -----
> 
>   src/common/protobuf_utils.cpp 1e795dcc90b2225ad7b0a124dbdcdabdc9d2e6aa 
>   src/messages/messages.proto 9a1564ff38fa1b984e92cb0abfde2108385f9e2a 
> 
> Diff: https://reviews.apache.org/r/39791/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message