mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 39710: Added test to verify downgrade from HTTP to PID based schedulers
Date Wed, 28 Oct 2015 20:06:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39710/#review104336
-----------------------------------------------------------

Ship it!



src/tests/scheduler_http_api_tests.cpp (line 520)
<https://reviews.apache.org/r/39710/#comment162587>

    s/if/that/



src/tests/scheduler_http_api_tests.cpp (line 521)
<https://reviews.apache.org/r/39710/#comment162589>

    since a PID scheduler doesn't have control over the 'force' field (it is done by the driver
under the covers), maybe lets not mention it?



src/tests/scheduler_http_api_tests.cpp (line 579)
<https://reviews.apache.org/r/39710/#comment162588>

    s/the/PID based/


- Vinod Kone


On Oct. 28, 2015, 4:54 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39710/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2015, 4:54 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   src/tests/scheduler_http_api_tests.cpp d338a1bc6fdb3aa0b40e5727991181b31b2e7592 
> 
> Diff: https://reviews.apache.org/r/39710/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message