mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 39400: Quota: Implemented quota API.
Date Tue, 27 Oct 2015 19:16:28 GMT


> On Oct. 26, 2015, 6:52 a.m., Qian Zhang wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 897
> > <https://reviews.apache.org/r/39400/diff/4/?file=1105059#file1105059line897>
> >
> >     I think we are not *moving" the role into the quota'ed role sorter, instead,
we are adding it into the quota'ed role sorter, i.e., quota'ed role will be placed in both
quota'd role sorter and the non-quota'ed role sorter.

My thinking was to stress that by doing that a different allocation algorithm applies. But
you're right, it's misleading.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39400/#review103984
-----------------------------------------------------------


On Oct. 23, 2015, 4:38 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39400/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 4:38 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3718
>     https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b

>   src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36

> 
> Diff: https://reviews.apache.org/r/39400/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message