mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 39410: Added support for github to apply-reviews.py.
Date Tue, 27 Oct 2015 18:58:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39410/#review104111
-----------------------------------------------------------



support/apply-reviews.py (line 38)
<https://reviews.apache.org/r/39410/#comment162343>

    either this function should renamed to something review board specific or the function
need to get both RB and GH users.



support/apply-reviews.py (lines 43 - 44)
<https://reviews.apache.org/r/39410/#comment162342>

    update comment?



support/apply-reviews.py (lines 76 - 78)
<https://reviews.apache.org/r/39410/#comment162344>

    bad rebase.



support/apply-reviews.py (line 105)
<https://reviews.apache.org/r/39410/#comment162345>

    if 'dry_run' in options:



support/apply-reviews.py (lines 149 - 155)
<https://reviews.apache.org/r/39410/#comment162346>

    i don't follow. why not just call 'shell(cmd)' if you want to override 'dry_run'? is it
because 'shell()' doesn't print the command?



support/apply-reviews.py (line 177)
<https://reviews.apache.org/r/39410/#comment162485>

    s/populate_//



support/apply-reviews.py (line 192)
<https://reviews.apache.org/r/39410/#comment162347>

    s/populate_//



support/apply-reviews.py (line 218)
<https://reviews.apache.org/r/39410/#comment162348>

    s/populate_//



support/apply-reviews.py (line 228)
<https://reviews.apache.org/r/39410/#comment162482>

    indentation?



support/apply-reviews.py (line 268)
<https://reviews.apache.org/r/39410/#comment162349>

    s/mututally/mutually/ ?


- Vinod Kone


On Oct. 23, 2015, 11:13 p.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39410/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 11:13 p.m.)
> 
> 
> Review request for mesos, Adam B, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and
Vinod Kone.
> 
> 
> Bugs: MESOS-3468
>     https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added support for github to apply-reviews.py.
> 
> 
> Diffs
> -----
> 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39410/diff/
> 
> 
> Testing
> -------
> 
> Tested with python 2.7
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message