mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.
Date Mon, 26 Oct 2015 17:35:21 GMT


> On Oct. 26, 2015, 1:51 p.m., Artem Harutyunyan wrote:
> > src/master/allocator/mesos/hierarchical.cpp, lines 1044-1046
> > <https://reviews.apache.org/r/39401/diff/5/?file=1105060#file1105060line1044>
> >
> >     s/the/that/
> >     
> >     Seems like a copy of the comment above, is this intentional?

Yep, in both cases we have to laid aside resources.


> On Oct. 26, 2015, 1:51 p.m., Artem Harutyunyan wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1057
> > <https://reviews.apache.org/r/39401/diff/5/?file=1105060#file1105060line1057>
> >
> >     s/guarantee/a guarantee/
> >     
> >     It'd be great to expand this comment a bit and describe what the gurantee represents.

Do you think this is a good place for that?


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39401/#review104010
-----------------------------------------------------------


On Oct. 23, 2015, 4:38 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39401/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 4:38 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3718
>     https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36

> 
> Diff: https://reviews.apache.org/r/39401/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message