mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.
Date Sat, 24 Oct 2015 18:43:24 GMT


> On Oct. 6, 2015, 5:12 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp, lines
41-43
> > <https://reviews.apache.org/r/39019/diff/2/?file=1091328#file1091328line41>
> >
> >     Is this necessary?  (Do the calls to `FindNextFile`, `FindClose`, or `FindFirstFile`
require C or something?)

I wrote this into the comments, but I wanted to make the linker not use C++ linkage style
that mangles the names. This will give the code the feeling of "real C standard library" code.

Yes, I admit it's a super nitpicky thing to do.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review101663
-----------------------------------------------------------


On Oct. 24, 2015, 6:42 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39019/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2015, 6:42 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3441
>     https://issues.apache.org/jira/browse/MESOS-3441
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Added dirent compat code for non-Unix systems.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp PRE-CREATION

>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 7a8819541506f57f70a9b577dc97a76fc26ebaa8

> 
> Diff: https://reviews.apache.org/r/39019/diff/
> 
> 
> Testing
> -------
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message