mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <>
Subject Re: Review Request 39548: SchedulerTest.Suppress is flaky
Date Fri, 23 Oct 2015 09:05:48 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated 十月 23, 2015, 9:05 a.m.)

Review request for mesos and Vinod Kone.


Address Anand's comments per IRC discussion

Bugs: MESOS-3733

Repository: mesos

Description (updated)

Root Cause: The reason is that the DECLINE call set filter as 1hr,
the Clock::advance set as 100m. A race condition is that both DECLINE
and SUPPRESS started up in different threads and the call Clock::advance
may be called before SUPPRESS finished. The clock advanced for 100m which
is greater than 1hr, this caused the allocator start to allocate resource
again and ASSERT_TRUE(event.isPending()) will be failed.

Solution: Make SUPPRESS call is finished before call Clock::advance

Diffs (updated)

  src/tests/scheduler_tests.cpp 7946cb48d62f4ed6d0fdbc771746518e31921f97 



Platform: Ubuntu 14.04
make check
bin/ --gtest_filter="ContentType/SchedulerTest.Suppress/*"  --gtest_repeat=-1


Guangya Liu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message