mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <alexan...@mesosphere.io>
Subject Re: Review Request 39276: Fixed a bug in which under certains circumstances HTTP 1.1 Pipelining is not respected.
Date Wed, 21 Oct 2015 09:35:53 GMT


> On Oct. 21, 2015, 3:47 a.m., Till Toenshoff wrote:
> > 3rdparty/libprocess/src/process.cpp, line 2351
> > <https://reviews.apache.org/r/39276/diff/4/?file=1099769#file1099769line2351>
> >
> >     The existing is incorrect but not sure which option is correct:
> >     
> >     A. s/event's/events'/
> >     B. s/event's/event/

Check [this](http://www.grammarbook.com/punctuation/apostro.asp) and went with _events'_.


> On Oct. 21, 2015, 3:47 a.m., Till Toenshoff wrote:
> > 3rdparty/libprocess/src/process.cpp, line 2349
> > <https://reviews.apache.org/r/39276/diff/4/?file=1099769#file1099769line2349>
> >
> >     There is something wrong with the commas and periods - please check with a native
speaker.

You're right, I checked some grammar books. No comma here.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39276/#review103336
-----------------------------------------------------------


On Oct. 16, 2015, 9:28 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39276/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2015, 9:28 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Bernd Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3705
>     https://issues.apache.org/jira/browse/MESOS-3705
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When using the same socket to send multiple HTTP requests to different actors. If the
actor responsible for handling the first request is stuck handling another event while a subsequent
request can reply immediatly, the order of the responses is altered violating HTTP Pipelining.
> 
> This patch fixes that problem enforcing that every response is sent in the order the
corresponding request arrived. It also adds a test to reproduce the issue and verify the fix
works.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/event.hpp 16ddbd77afa6efdf6bad201aa497ee102aa863ae

>   3rdparty/libprocess/src/process.cpp 954d31424bc8f8ecfa78b80513c480f2514ec271 
>   3rdparty/libprocess/src/tests/http_tests.cpp d13d3888abbf3db552df4a9f83e54667e598ded9

> 
> Diff: https://reviews.apache.org/r/39276/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message