mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Artem Harutyunyan" <ar...@mesosphere.io>
Subject Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.
Date Wed, 21 Oct 2015 06:06:27 GMT


> On Oct. 20, 2015, 2:55 p.m., Marco Massenzio wrote:
> > support/apply-review.sh, line 3
> > <https://reviews.apache.org/r/39420/diff/3/?file=1101523#file1101523line3>
> >
> >     I really dislike this style of conditional running stuff in bash (it also violates
Google's style, but that's another story :) )
> >     ```
> >     if [[ ! -f "support/apply-reviews.py" ]]; then
> >         echo "..."
> >         exit 1
> >     fi
> >     
> >     python ./support/apply-reviews.py "$@"
> >     ```

I asked this during one of the community syncs and folks thought that we should preserve `apply-review.sh`
for at least a couple of releases. The [-f ..] here is just a guard to make sure that the
script is ran from the root of the source tree.


- Artem


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review103312
-----------------------------------------------------------


On Oct. 20, 2015, 11:04 p.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 11:04 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and Vinod
Kone.
> 
> 
> Bugs: MESOS-3468
>     https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added '--parent' option and made apply-review.sh call apply-reviews.py.
> 
> 
> Diffs
> -----
> 
>   support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39420/diff/
> 
> 
> Testing
> -------
> 
> Tested with python 2.7.
> 
> - with and without '-p'.
> - Tested reviews with and without parents.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message