mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 39331: Support docker local store pull image simultaneously
Date Tue, 20 Oct 2015 23:28:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39331/#review103327
-----------------------------------------------------------


Patch looks great!

Reviews applied: [39331]

All tests passed.

- Mesos ReviewBot


On Oct. 20, 2015, 9:22 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39331/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 9:22 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3736
>     https://issues.apache.org/jira/browse/MESOS-3736
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Support docker local store pull image simultaneously
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/provisioner/docker/metadata_manager.cpp 2b2de5245bccbd01a856b214ac6525278d794537

>   src/slave/containerizer/provisioner/docker/store.cpp 50340131d10222ac06cf21e87ad46943f171d1f6

>   src/tests/containerizer/provisioner_docker_tests.cpp 01d3025f59d4a2714a856fe0f3a57192be023990

> 
> Diff: https://reviews.apache.org/r/39331/diff/
> 
> 
> Testing
> -------
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> *This is not ready to be merged.
> *Still considering two question:
>  1. Handling simultaneous failure. If the first request is called and is written into
the hashmap. All the other requests will be waiting for the future of the first request. But
because its return type is 'Future<vector<string>>', if its future status is 'FAILED/DISCARDED',
the other requests will be waiting forever. 
>  2. The current hashmap uses 'stringify(image::name)' as key, but it may not be unique
because there is chance that layer_ids can be changed. One solution is to have 'stringify(image)'
as key.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message