mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Artem Harutyunyan" <ar...@mesosphere.io>
Subject Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).
Date Tue, 20 Oct 2015 07:27:37 GMT


> On Oct. 19, 2015, 1:04 p.m., Vinod Kone wrote:
> > support/apply-reviews.py, lines 49-52
> > <https://reviews.apache.org/r/38705/diff/8/?file=1100640#file1100640line49>
> >
> >     i don't follow what's happening here. you are appending the same <rid,summary>
pair multiple times to the list?

Not exactly, but I refactored this part so it should be clear now.


- Artem


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38705/#review103147
-----------------------------------------------------------


On Oct. 18, 2015, 3:30 p.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38705/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2015, 3:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, Joseph Wu, and Vinod
Kone.
> 
> 
> Bugs: MESOS-3468
>     https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38705/diff/
> 
> 
> Testing
> -------
> 
> Tested the script with python 2.7.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message