mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <>
Subject Re: Review Request 39338: Added code that appends the fetcher log to the agent log upon fetcher failure.
Date Fri, 16 Oct 2015 08:56:08 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 16, 2015, 1:56 a.m.)

Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and Timothy Chen.


Followed @bbannier's advice.

Bugs: MESOS-3743

Repository: mesos


Added an onFailed() clause to the inspection of the fetcher subprocess run. This clause copies
the fetcher log from <task sandbox>/stderr and appends it to the agent log.

This is to facilitate debugging spurious fetch failures in production or CI.

Similar, but not the same: (see MESOS-3743 for an explanation).

Diffs (updated)

  src/slave/containerizer/fetcher.cpp 2b2298c329ed5fb5863cb0fed1491e478c3e5d5a 



Ran make check. As expected no change in behavior.
When I modified the fetcher to fail, 
I observed the expected extra output.


Bernd Mathiske

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message