mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 39250: Puller refactor: moved untar to a common place
Date Thu, 15 Oct 2015 22:51:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39250/#review102827
-----------------------------------------------------------

Ship it!


Ship It!


src/slave/containerizer/provisioner/docker/puller.hpp (line 70)
<https://reviews.apache.org/r/39250/#comment160633>

    target directory to be more clear


- Timothy Chen


On Oct. 14, 2015, 12:45 a.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39250/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2015, 12:45 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Puller refactor: moved untar to a common place
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/provisioner/docker/local_puller.cpp 74d0e1ead7d630e65a7e75cb6123139b9197efef

>   src/slave/containerizer/provisioner/docker/puller.hpp 105b4e75439c2ad4c08e2fd364f288f1d39b9b59

>   src/slave/containerizer/provisioner/docker/puller.cpp cb05324689ffa26ce830b513e2d71b55517da3cb

>   src/slave/containerizer/provisioner/docker/remote_puller.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39250/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message