mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Bannier" <>
Subject Re: Review Request 39005: stout: Added thread-safe replacement for strerror.
Date Fri, 09 Oct 2015 14:24:22 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 9, 2015, 2:24 p.m.)

Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.


Widdened supported glibc versions.

strerror_r is broken on <=glibc-2.15 only if certain defines are set, so we can support
more setups (the current patch compiles and checks e.g. under CentOS-5.11).

Bugs: MESOS-3551

Repository: mesos


This adds a thread-safe wrapper around strerror_r which has semantics similar to strerror.
We plan to use this at call sites currently relying on strerror.

Diffs (updated)

  3rdparty/libprocess/3rdparty/stout/include/ 9e9c3119ad18f4cbc70c70095c71dc4fd19553df

  3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp e6d36ec1bf414b52d0899f0edf83e0ad8910dd0e



make check


Benjamin Bannier

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message