mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <mazumdar.an...@gmail.com>
Subject Re: Review Request 39141: Store: minor style changes
Date Thu, 08 Oct 2015 19:40:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39141/#review101951
-----------------------------------------------------------



src/slave/containerizer/provisioner/docker/store.cpp (line 202)
<https://reviews.apache.org/r/39141/#comment159462>

    In this particular case, `push_back` would also do a `std::move` for a temporary object
and I wonder why do we even need `emplace_back` here ?
    
    I even don't know if an overload like `emplace_back(T&& value)` even existed and
how does it compile even ?
    
    http://en.cppreference.com/w/cpp/container/vector/emplace_back


- Anand Mazumdar


On Oct. 8, 2015, 7:30 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39141/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2015, 7:30 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Store: minor style changes
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/provisioner/docker/store.cpp cbb67686d45513f0395a0cf1bc5c43cb4935adae

> 
> Diff: https://reviews.apache.org/r/39141/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message