mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 37024: Exposes mesos version information in components.
Date Tue, 06 Oct 2015 01:21:08 GMT


> On Oct. 6, 2015, 1:16 a.m., Ben Mahler wrote:
> > src/version/version.hpp, line 43
> > <https://reviews.apache.org/r/37024/diff/7/?file=1091482#file1091482line43>
> >
> >     Hm.. I'm confused as to how you can initialize this non-static member in the
.cpp file as you're doing now. Can you please follow the approach in metrics.cpp?
> >     
> >     https://github.com/apache/mesos/blob/master/3rdparty/libprocess/src/metrics/metrics.cpp#L67

Alternatively, feel free to follow the approach from monitor.cpp:

https://github.com/apache/mesos/blob/master/src/slave/monitor.cpp#L45


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/#review101571
-----------------------------------------------------------


On Oct. 6, 2015, 1:14 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37024/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2015, 1:14 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1841
>     https://issues.apache.org/jira/browse/MESOS-1841
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add an endpoint exposes Apache Mesos build informations and version information.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba 
>   src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1 
>   src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f 
>   src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734 
>   src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d 
>   src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9 
>   src/version/version.hpp PRE-CREATION 
>   src/version/version.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37024/diff/
> 
> 
> Testing
> -------
> 
> Manual test result:
> 
> ```
> $ curl http://localhost:5050/version 2>/dev/null|jq .
> 
> {
>   "version": "0.24.0",
>   "build_user": "haosdent",
>   "build_time": 1439702338,
>   "build_date": "2015-08-16 13:18:58"
> }
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message